[10.x] Fix collection shift less than one item #51686

faissaloux · 2024-06-02T20:11:17Z

Helloo 👋🏻

In this PR I have fixed the collection shift() behaviour when trying to shift less than one item.

$count = 0

Current

$collection = new Collection(['foo', 'bar', 'baz']);
echo $collection->shift(0); // ['foo', 'bar']
echo $collection; // ['baz']

Expected

$collection = new Collection(['foo', 'bar', 'baz']);
echo $collection->shift(0); // []
echo $collection; // ['foo', 'bar', 'baz']

$count < 0

Current

$collection = new Collection(['foo', 'bar', 'baz']);
echo $collection->shift(-1); // ['foo', 'bar', 'baz']
echo $collection; // []

Expected

$collection = new Collection(['foo', 'bar', 'baz']);
echo $collection->shift(-1); // InvalidArgumentException

src/Illuminate/Collections/Collection.php

fix collection shift less than 1

5fb9fd5

faissaloux changed the title ~~[10.x] Fix collection shift less than 1~~ [10.x] Fix collection shift less than one item Jun 2, 2024

fgaroby reviewed Jun 3, 2024

View reviewed changes

src/Illuminate/Collections/Collection.php Show resolved Hide resolved

faissaloux and others added 2 commits June 3, 2024 11:50

throw exception earlier

553426a

Update Collection.php

b31ed7c

taylorotwell merged commit 8154eb6 into laravel:10.x Jun 3, 2024
24 checks passed

faissaloux deleted the fix-collection-shift branch June 3, 2024 13:27

YazeedAlsaif mentioned this pull request Jun 3, 2024

[10.x] Fix collection items pop when count is 0 or less than 0. #51699

Closed

This was referenced Jun 19, 2024

[10.x] collection shift can not handle an empty collection #51840

Closed

[10.x] fix handle shift() on an empty collection #51841

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10.x] Fix collection shift less than one item #51686

[10.x] Fix collection shift less than one item #51686

faissaloux commented Jun 2, 2024 •

edited

Loading

[10.x] Fix collection shift less than one item #51686

[10.x] Fix collection shift less than one item #51686

Conversation

faissaloux commented Jun 2, 2024 • edited Loading

$count = 0

Current

Expected

$count < 0

Current

Expected

faissaloux commented Jun 2, 2024 •

edited

Loading